Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextField - fix for centered input #3182

Merged
merged 6 commits into from
Jul 24, 2024
Merged

Conversation

Inbal-Tish
Copy link
Collaborator

Description

TextField - fix for centered input
Fix for this PR: #3178

Changelog

TextField - fix for centered input

Additional info

@Inbal-Tish Inbal-Tish requested a review from ethanshar July 18, 2024 06:12
@Inbal-Tish Inbal-Tish added the Important for Next Release PR that must be included in the release version label Jul 18, 2024
Copy link
Collaborator

@ethanshar ethanshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rendered a few scenarios with centered mode that looks a little weird
I think it's better we ask the UX to prepare guidelines for centered text field and how they want all the surrounding elements to behave
For example

  • a centered text field with (only) character counter looks weird
  • When I render the following it also looks strange, the validation is centered but the helper text is not
<TextField
  placeholder="Placeholder"
  validationMessage="This is an error message, a really long validation message"
  helperText="This is a helper text"
  bottomAccessory={<Text>This is a bottom accessory</Text>}
  showCharCounter
   maxLength={20}
   centered
/>

Maybe those are edge cases but I don't want us to create a too complex layout that will give us issues in the future

@Inbal-Tish Inbal-Tish merged commit 7b97866 into master Jul 24, 2024
1 check passed
@Inbal-Tish Inbal-Tish deleted the fix/TextField_centered branch July 24, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Important for Next Release PR that must be included in the release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants