TextField - only use leadingAccessoryRef when needed (i.e. floatingPlaceholder={true}) #3197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TextField - only use leadingAccessoryRef when needed (i.e. floatingPlaceholder={true})
If the user has a function component for
leadingAccessory
:They will get an error since we require a ref for the
leadingAccessory
and in a function component it needs to be forwarded.One solution is to use
React.forwardRef
, however this can be avoided in cases wherefloatingPlaceholder={false}
because that's the only reason to have theref
.Changelog
TextField - only require
leadingAccessory
to have a ref when needed (i.e. floatingPlaceholder={true})Additional info
Channel (Aug. 1st)