Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new type for Stepper component - floating #3247

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Add new type for Stepper component - floating #3247

merged 3 commits into from
Sep 11, 2024

Conversation

ethanshar
Copy link
Collaborator

Description

Add new type for Stepper component - floating

Changelog

Add new type for Stepper component - floating

Additional info

MADS-4319

@ethanshar ethanshar requested a review from adids1221 September 5, 2024 13:31
@ethanshar ethanshar added the Important for Next Release PR that must be included in the release version label Sep 5, 2024
adids1221
adids1221 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@adids1221 adids1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
A small comment, since the usage of the floating Stepper is on another component let's add at least one example to the screen, WDYT ?
Of course this could be in another PR.

@ethanshar
Copy link
Collaborator Author

Approved. A small comment, since the usage of the floating Stepper is on another component let's add at least one example to the screen, WDYT ? Of course this could be in another PR.

Done ✅

@ethanshar ethanshar enabled auto-merge (squash) September 11, 2024 14:00
@ethanshar ethanshar merged commit f585b05 into master Sep 11, 2024
1 check passed
@ethanshar ethanshar deleted the feat/Stepper_floatingType branch September 11, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adids1221 adids1221 adids1221 approved these changes

Assignees

@adids1221 adids1221

Labels
Important for Next Release PR that must be included in the release version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanshar @adids1221