Make Constants.statusBarHeight dynamic on phone orientation change #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
approved these changes
Sep 16, 2024
ethanshar
deleted the
make-status-bar-height-dynamic-on-phone-orientation-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
inside Constants.ts made statusBarHeight dynamic to mobile orientation changes
Instead of using StatusBarManager.HEIGHT, now setStatusBarHeight will use StatusBarManager.getHeight() method which provides the right height when called (HEIGHT is declared once when the app initialized)
When starting IOS application in landscape mode and then changing to portrait statusBarHeight value wont change and remain 0.
Changelog
Fix statusBarHeight value to by dynamic when changing orientation