refactor: simplify RTL handling in tab controller components #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ethanshar Iv'e checked it both on Android and IOS, also on the private repo ( |
ethanshar
reviewed
Dec 12, 2024
| @@ -177,12 +178,13 @@ const useScrollToItem = <T extends ScrollToSupportedViews>(props: ScrollToItemPr | |||
|
|
|||
| const focusIndex = useCallback((index: number, animated = true) => { | |||
| if (index >= 0 && offsets.CENTER.length > index) { | |||
| const rtlIndex = Constants.isRTL && Constants.isIOS ? itemsCount - index - 1 : index; | |||
There was a problem hiding this comment.
Let's move Constants.isRTL && Constants.isIOS to a const at the top of the file like we did before so it's easier to spot there's an RTL fix
M-i-k-e-l
approved these changes
Dec 12, 2024
M-i-k-e-l
added a commit
that referenced
this pull request
Dec 12, 2024
* refactor: simplify RTL handling in tab controller components * Move to FIX_RTL const --------- Co-authored-by: M-i-k-e-l <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TabControllersupport RTL on IOS and Android.After the RN 73 upgrade there isn't and RTL issue on Android but on IOS.
Fixing the issue in
TabControllerby reversing the selected index when using RTL on IOS.Changelog
TabControllersupport RTL on IOS and Android.Additional info
MADS-4571