descriptors: fix unsigned tx max satisfaction weight #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't reviewed the test nor the context but the code looks good to me, for what it's worth. |
Errors in the weight calculation could be hidden when converting to vbytes. This separate method will make it easier to spot any such errors.
jp1ac4
force-pushed
the
desc-fix-unsigned-tx-max-weight
branch
from
500ae75 to
e4ae6dc
Compare
|
Rebased on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1406, building on the fix from #1451 for estimating the weight of each input.
An extra 2 is added to the unsigned transaction's weight to account for the Segwit marker and flag.