Implemenet fs.hash() #476
Implemenet fs.hash() #476
Conversation
|
@lll000111 Sorry for taking so long, I'm really appreciate your great work 👍 Just encounter some problem when I'm trying to build the IOS project there're some errors seemed to be related to this PR. Could you check if there's something missed ?
|
|
There is a later patch with a missing "import ..." for the hash function, all the digest code. Line 16: All mixed together, not a good commit, I admit. |
|
PS: Having done quite a bit of bug searching and patching in my life and knowing the value of being able to go step by (small) step, I think in this particular case it is easier if you just take in the whole PR at once and check it as one thing. And somebody (I guess that means you) has to run the tests on iOS... but the "fs" tests should suffice if you don't have much time. I didn't really touch the fetch-related stuff. |
|
I made some changes to the hash for IOS. The hash is import for our project. We use a signed URL from our server to put the blob on AWS S3. If you want I can create a PR for IOS fixes |
…h237#476) # Conflicts: # android/src/main/java/com/RNFetchBlob/RNFetchBlob.java
…ash" (wkh237#476)" This reverts commit 1488919.
* upstream/0.10.9: Fixed problem with type casting (wkh237#513) My proposed 0.10.9 changes (wkh237#489) wkh237#268 Cancelled task should not trigger `then` promise function Add ability to cancel android DownloadManager fetches (wkh237#502) Fix iOS initialization race condition (wkh237#499) prevent UIApplication methods from being called on background thread (wkh237#486) Implemenet fs.hash() -- wkh237#439 "Feature: Calculate file hash" (wkh237#476) I forgot one error string for the Android readFile() method (wkh237#475) Fix for wkh237#467 (wkh237#472) Fix for issue wkh237#468, wkh237#461, wkh237#460 and minor cleanup (wkh237#469)
This implements
fs.hash(...)(link) from ticket #439While this is a FEATURE patch I propose this to go into 0.10.9, since it involves zero code changes for any other code. If you disagree I'll resubmit the PR for 0.11.
I only tested it on Android, the code is from https://github.com/itinance/react-native-fs