-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change duplicate notations in tables 1-01-* and 5-02-* #474
Comments
I accept some of the (shared) responsibility for not having scrutinized these tables sufficiently before the previous amendments went to FT. These duplicate notations - even though in different name spaces - create difficulties for OSCAR/Surface, but they may also lead to risk of confusion and errors of the users. We should keep the notations unique acroos these sub-tables. The odds are that the effect will be minimal if quickly reacted to, which means I would favor a correction of the codes registry using the 'experimental' flag, in combination with an announcement in the operational WMO letter, and followed of course with a regular CR as part of FT-2023-2. |
https://github.com/wmo-im/tt-wigosmd/wiki/2023.04.06-TT-WIGOSMD notes:
|
ObservedVariables
ObservingMethods
|
Branch is updated but I think this needs to go through the official fast-track procedure because the codes with the old notations will be superseded by the codes with the new notations. I can't simply change the notation in the registry and change the status to 'experimental'. I can only add new notations with the status of 'experimental' and change the status of the superseded codes to 'superseded'. |
The only value that I think I can fix now, is fog collection, because it used to be polarized lidar (same notation, same table). |
+1 on going through the FT ... but, technically, you can make the changes already know, and tag them with experimental. Am I missing something? |
https://github.com/wmo-im/tt-wigosmd/wiki/2023.04.21-TT-WIGOSMD notes: |
https://github.com/wmo-im/tt-wigosmd/wiki/2023.05.04-TT-WIGOSMD notes: |
https://github.com/wmo-im/tt-wigosmd/wiki/2023.06.01-TT-WIGOSMD notes: |
@amilan17 to update branch |
@jbianchi81 -- I need to change the notations for some of the hydro methods that were recently added. They are not implemented in OSCAR/Surface yet and I'm hoping that the hydro community is not using them yet either. Can you confirm? |
Yes, you may proceed |
@jbianchi81 Thank you for your quick response. I have the same question for observed variables... |
@amilan17 same answer... |
Discovered more dupe notations in 1-01-01 and 1-01-05 (introduced in FT2023-1). I will update the FT2023-1 release BEFORE I update the codes registry!
|
@amilan17 Please update initial request to suggest what the request is. As it stands, it's just a problem statement. |
Initial request
OSCAR/Surface parser currently only looks at the last element of a URL and expects a notation that is unique across the entire “namespace” of the element. Thus, the artificial separation of ObservedVariable* and ObservingMethod* into several code tables is essentially ignored by OSCAR/surface.
Amendment details
updated 15 Aug 2023
supersede with new notations to avoid duplicates across similar tables
3444173454183464193474203484213494221224512320122461232112244123191224712322122481232312249123241225112325Comments
It might be useful to develop some best practices on how to assign numerical notations in such a way that will ensure no duplication, rather than querying all tables to find out what number is the highest.
Requestor(s)
@amilan17 @fstuerzl @luciacap
Stakeholder(s)
Publication(s)
Example: Manual on Codes (WMO-No. 306), Volume I.3, WMO Codes Registry, Code tables 1-01-01, 1-01-03, 1-01-05, 5-02-01 and 5-02-05
Expected impact of change
MEDIUM
Collaborators
No response
References
No response
Validation
No response
The text was updated successfully, but these errors were encountered: