-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create 5-02-03.csv #439
Create 5-02-03.csv #439
Conversation
Create 5-02-03.csv for initial Measurement/observing method (ocean)
tables_en/5-02-03.csv
Outdated
,,,,(flux) that diffuse through the membrane from the ocean environment to the working electrode | ||
,ocean,"ocean,dissolved oxygen",Oxygen luminescence quenching method,The fluorescent indicator is a special complex embedded in a gas permeable sensing foil that is exposed to the surrounding water. The sensing foil is excited by modulated light; the sensor measures the phase of the returned light. | ||
,ocean,"ocean,pH",Potentiometric method,ion-sensitive field-effect transistor that responds to proton activity and | ||
,,,,a Ag/AgCl reference electrode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anthoninlize Is "a Ag/AgCl reference electrode" supposed to be a part of the definition for "Potentiometric"? Right now it appears in a new row preceded by empty cells.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh, indeed. I can update. What's the best way to handle this there? Closing this pull request and create another one with the fix?
tables_en/5-02-03.csv
Outdated
,ocean,"ocean,waves,direction,period,height",HF echo doppler spectra analysis method (HR radar),Remote sensing of surface currents employing radars frequencies | ||
,ocean,"ocean,current,direction,speed",GPS fixes sequence comparison,Measurement derived from the difference between two successives GPS positions | ||
,ocean,"ocean,dissolved oxygen",Clark electrode polarographic method,The dissolved oxygen concentration by counting the number of oxygen molecules per second | ||
,,,,(flux) that diffuse through the membrane from the ocean environment to the working electrode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this part of the definition for "Clark electrode polarographic method"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anthoninlize Thank you for creating this table. It looks like there are some errors in the CSV. May I also ask that you make the sentences complete (with a period at the end). Thanks.
Fixing breaking CSV and adding periods where missing.
Sorry for that. I updated the CSV and re-requested a review. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating. It looks good now. You can add notations as well.
Should notations be numbers or based on the name, following https://github.com/wmo-im/wmds/wiki/Guidance-for-spelling-of-notation? |
Adding notations
e95807c
into
wmo-im:422-new-table-5-02-03-measurementobserving-method-ocean
Create 5-02-03.csv for initial Measurement/observing method (ocean)