Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 5-02-03.csv #439

Conversation

anthoninlize
Copy link
Contributor

Create 5-02-03.csv for initial Measurement/observing method (ocean)

Create 5-02-03.csv for initial Measurement/observing method (ocean)
,,,,(flux) that diffuse through the membrane from the ocean environment to the working electrode
,ocean,"ocean,dissolved oxygen",Oxygen luminescence quenching method,The fluorescent indicator is a special complex embedded in a gas permeable sensing foil that is exposed to the surrounding water. The sensing foil is excited by modulated light; the sensor measures the phase of the returned light.
,ocean,"ocean,pH",Potentiometric method,ion-sensitive field-effect transistor that responds to proton activity and
,,,,a Ag/AgCl reference electrode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anthoninlize Is "a Ag/AgCl reference electrode" supposed to be a part of the definition for "Potentiometric"? Right now it appears in a new row preceded by empty cells.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh, indeed. I can update. What's the best way to handle this there? Closing this pull request and create another one with the fix?

,ocean,"ocean,waves,direction,period,height",HF echo doppler spectra analysis method (HR radar),Remote sensing of surface currents employing radars frequencies
,ocean,"ocean,current,direction,speed",GPS fixes sequence comparison,Measurement derived from the difference between two successives GPS positions
,ocean,"ocean,dissolved oxygen",Clark electrode polarographic method,The dissolved oxygen concentration by counting the number of oxygen molecules per second
,,,,(flux) that diffuse through the membrane from the ocean environment to the working electrode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this part of the definition for "Clark electrode polarographic method"?

Copy link
Member

@amilan17 amilan17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anthoninlize Thank you for creating this table. It looks like there are some errors in the CSV. May I also ask that you make the sentences complete (with a period at the end). Thanks.

Fixing breaking CSV and adding periods where missing.
@anthoninlize anthoninlize requested a review from amilan17 January 13, 2023 16:02
@anthoninlize
Copy link
Contributor Author

Sorry for that. I updated the CSV and re-requested a review. Thanks

Copy link
Member

@amilan17 amilan17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating. It looks good now. You can add notations as well.

@anthoninlize
Copy link
Contributor Author

Should notations be numbers or based on the name, following https://github.com/wmo-im/wmds/wiki/Guidance-for-spelling-of-notation?
If number, I assign them purely incrementally?

Adding notations
@amilan17 amilan17 merged commit e95807c into wmo-im:422-new-table-5-02-03-measurementobserving-method-ocean Jan 16, 2023
@anthoninlize anthoninlize deleted the patch-1 branch April 3, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants