update branch for issue #391 #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amilan17
force-pushed
the
391-NEW-1-01-01-addition-of-variable-definitions-part-2-lightning
branch
from
692e484 to
f346c4e
Compare
amilan17
deleted the
391-NEW-1-01-01-addition-of-variable-definitions-part-2-lightning
branch
amilan17
added a commit
that referenced
this pull request
Aug 20, 2024
* update branch for issue #391 * Github Action Commit --------- Co-authored-by: Anna Milan <[email protected]> Co-authored-by: joergklausen <[email protected]>
amilan17
added a commit
that referenced
this pull request
Nov 7, 2024
* update branch for issue #391 (#538) * update branch for issue #391 * Github Action Commit --------- Co-authored-by: Anna Milan <[email protected]> Co-authored-by: joergklausen <[email protected]> * 443 1 01 01 addition of definitions for cloud variables (#537) * Update 1-01-01.csv * Update 1-01-01.csv * Github Action Commit --------- Co-authored-by: Franziska Stürzl <[email protected]> Co-authored-by: joergklausen <[email protected]> * add core and recommended (#544) * add flash definitions (#545) #391 * Github Action Commit * issue Bug: Superseded unit in WMDR code table #520 (#540) #520 * Update 1-01-01.csv editorial revision to definition of 507 * Github Action Commit * Update 1-01-01.csv editorial * Github Action Commit * Update 9-02.csv editorial * Revise datapolicy (#546) * Update 9-02.csv #475 * Update 9-02.csv * Update 9-02.csv re-order * Update 9-02.csv (#547) remove comparisons to previous data policies * Apply suggestions from code review replace issue numbers with sequential notation numbers --------- Co-authored-by: Jörg Klausen <[email protected]> Co-authored-by: joergklausen <[email protected]> Co-authored-by: Franziska Stürzl <[email protected]> Co-authored-by: amilan17 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 432 and 433, the new name includes the word 'discharge', which is not found in the issue. I cannot really judge the significance of this, but it seems minor.
For 12001 and 12002, the parentheses around the word 'flash' are not included in the name, unlike found in the issue. This is insignificant.