Increased API coverage of QRgba64 and Qrgb #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QRgba64 is now derived from the C++ class rather than implemented in Rust. Additionally, some conversions were added. Conversion from u64 to QRgba64 is not currently implemented due to endian-ness concerns.
What's the rationale? Having it implemented in rust if probably much more efficient for such low level API. When using QRgba64, one want to use it as light class, and it ideally should be Copy and use bit shuffling to extract the color without going through a function call in C++ |
|
If we do that you might have to change the license to LGPL. We could create a Rust version but it would need to be compatible and have the same internal representation since it is used for SIMD applications, which makes many of the operations exactly identical in code. I could do it if you really want but it seems a bit strange to do it this way when the implementation is already there. |
QRgba64 is now fully implemented in Rust. Additionally, some conversions were added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QRgba64 is now derived from the C++ class rather than implemented in Rust.
Additionally, some conversions were added.
Conversion from u64 to QRgba64 is not currently implemented due to endian-ness concerns.