Improve ERD2W tab switching behaviour #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cause stale values to be used. E.g. when switching from inspect to edit causes the displayPropertyKeys to change. For the same reason, reset _currentTab when clearTabSectionsContents is called.
…b. This ensures the current tab will be kept active when a switch from e.g. inspect to edit causes the number of tabs or their order to change. If the current tab is no longer available, fall back to the first tab. Implement equals() with comparising limited to the name, as the default will only compare memory addresses, resulting in false negatives.
… setTabByName is no longer necessary, as the current tab is being reset with the call to clearTabSectionsContents.
…ill cause a page refresh. This change ensures the current tab will be kept active, as with an ajax update. The tab is identified via its name only, allowing for changes in the displayed property keys and the order of tabs. If the current tab is not available anymore, the first tab is selected.
|
Works for me. Much better behavior, even if the number of tabs changes. |
darkv
added a commit
that referenced
this pull request
Nov 29, 2015
Improve ERD2W tab switching behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current tab page implementation has some issues, especially when using ajax. When a new ERD2WContainer is instantiated, the navigation will fail, as the default equals() implementation then always returns false. The selected tab is lost when switching from inspect to edit. Changes to the tabSectionsContents (addition or removal of tabs or property keys) will not be honored on switching via ajax from inspect to edit mode.
To remedy these, the tab name is used as the identifier instead of the index of the tab in the tab sections contents. An equals() implementation that compares only the names is added. The caching behaviour is modified to prevent stale tab sections contents from being returned.