Update wordpress monorepo (major)

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
@wordpress/browserslist-config	3.0.3 -> 4.1.0
@wordpress/scripts	15.0.1 -> 17.1.0

---

Release Notes

WordPress/gutenberg

v4.1.0

Compare Source

v4.0.1

Compare Source

Changelog

• Deactivate plugin versions below 4.1 on WordPress 5.0. #​11375

v4.0.0

Compare Source

Breaking Change

• Upgraded React components to work with v17.0 (#​29118). There are no new features in React v17.0 as explained in the blog post.

---

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

---

• If you want to rebase/retry this PR, check this box.

---

This PR has been generated by WhiteSource Renovate. View repository job log here.

[Aljullu]

The changes in this PR drop IE11 support, so we should wait until an official decision is taken before merging it.

[nerrad]

It looks like in this case the primary impact comes from the @wordpress/browserlist-config update?

[Ismail-elkorchi]

#1674 Have already added ES6 syntax in the front-end js files, which is an implicite decision to drop IE11 support.

[senadir]

@Ismail-elkorchi I couldn't find any ES6 specific syntax in that PR, can you point me to the file?

[Ismail-elkorchi]

@senadir There is some usage of the keywords let and const in the files below :

https://github.com/woocommerce/storefront/blob/trunk/assets/js/footer.js#L48
https://github.com/woocommerce/storefront/blob/trunk/assets/js/homepage.js#L25
https://github.com/woocommerce/storefront/blob/trunk/assets/js/navigation.js#L169
https://github.com/woocommerce/storefront/blob/trunk/assets/js/sticky-add-to-cart.js#L57

Note that I only listed some occurrences of using the let keyword, but you can find const in the same files.

[senadir]

Agree, thanks for pointing them out @Ismail-elkorchi
Let and Const are partially supported in IE 11 (mainly, they don't work correctly inside loops)

I think it would be safer to just revert back to var cc @nerrad

[nerrad]

I think it would be safer to just revert back to var cc @nerrad

I agree, but lets wait for the pending conversation internally here: pcShBQ-2a-p2 as this could have application on when we remove IE11 support (and thus whether we will do anything or simply remove IE11 support more broadly across Storefront).

The changes in #1674 were just released last week so we can watch from any reports from IE11 users and if necessary revert the changes but for now the IE11 usage percentage is low enough that I'm not concerned about any immediate action needed at the moment.

[Aljullu]

Since the last time we discussed about merging this PR, a Developer Advisory about dropping support for IE11 in WooCommerce products has been published and next version of Storefront will include some changes that remove support for IE11 (see #1653), so I think we are good merging this PR. I did some smoke testing with Firefox and couldn't find any regressions.