Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress 6.7 Compatibility: Fix the issue that E2E test can't log in to wp-admin #472

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

With WordPress 6.7-RC3, the E2E test failed to start due to match two elements when trying to click the "Log In" button.

Trying to log-in as admin...
Admin log-in failed, Retrying... 0/5
locator.click: Error: strict mode violation: locator('text=Log In') resolved to 2 elements:
    1) <h1 class="screen-reader-text">Log In</h1> aka getByRole('heading', { name: 'Log In' })
    2) <input type="submit" id="wp-submit" value="Log In" name="wp-submit" class="button button-primary button-large"/> aka getByRole('button', { name: 'Log In' })

This PR ensures that it can locate the "Log In" button.

Checks:

  • Does your code follow the WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Detailed test instructions:

View the successful run: https://github.com/woocommerce/woocommerce-google-analytics-integration/actions/runs/11792649422/job/32846651874

Changelog entry

Dev - WordPress 6.7 Compatibility: Fix the issue that E2E test can't log in to wp-admin.

@eason9487 eason9487 self-assigned this Nov 12, 2024
@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Nov 12, 2024
@eason9487
Copy link
Member Author

I will be skipping code review for this PR as it's a developer-facing only change and a similar fix has been reviewed and approved.

@eason9487 eason9487 merged commit 9807314 into trunk Nov 12, 2024
4 checks passed
@eason9487 eason9487 deleted the dev/compat-wp-6-7-e2e-test branch November 12, 2024 07:39
@eason9487 eason9487 mentioned this pull request Nov 14, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant