Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace WooCommerce logo to Woo 2.0 Brand #489

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

eason9487
Copy link
Member

@eason9487 eason9487 commented Jan 20, 2025

Changes proposed in this Pull Request:

PT: peeuvX-1Wl-p2

This PR replaces the assets in the wordpress_org_assets directory with Woo 2.0 branded version.

📌 Checklist before merging (@eason9487)

  • [ ] Wait until the official launch date is near
    • The official launch date is February 4, 2025, so it can be merged between January 30 and February 3

The checklist is not needed. See #489 (review)

Checks:

  • Does your code follow the WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Detailed test instructions:

💡 This change will take effect after the new version is published to WPORG, so there is probably no practical way to test it.

  • View the new assets to see if there is any concern.

Changelog entry

Tweak - Replace WooCommerce logo to Woo 2.0 Brand.

@eason9487 eason9487 requested a review from a team January 20, 2025 08:20
@eason9487 eason9487 self-assigned this Jan 20, 2025
@github-actions github-actions bot added the changelog: tweak Small change, that isn't actually very important. label Jan 20, 2025
Copy link
Contributor

@mikkamp mikkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the new logos, they look good to me.

The official launch date is February 4, 2025, so it can be merged between January 30 and February 3

WooRelease doesn't automatically update these assets when a release is done. So we can go ahead and merge the PR. We'll just need to set a reminder to manually submit them to WordPress.org on the 4th of February, using svn.

https://plugins.trac.wordpress.org/browser/woocommerce-google-analytics-integration/assets

@eason9487 eason9487 merged commit 09f8f81 into trunk Jan 21, 2025
2 checks passed
@eason9487 eason9487 deleted the tweak/wc-v2-brand branch January 21, 2025 02:24
@ianlin ianlin mentioned this pull request Jan 21, 2025
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants