Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new required props to RouterProvider #53433

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Add new required props to RouterProvider #53433

merged 2 commits into from
Dec 4, 2024

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Dec 4, 2024

Changes proposed in this Pull Request:

(Same PR as #53352 but now targetting WC 9.5, as the PRR wasn't approved.)

This PR fixes an issue between Customize Your Store and the most recent nightly of Gutenberg. The changes in the API were introduced in WordPress/gutenberg#67199 (thanks @gigitux for pointing it out!).

How to test the changes in this Pull Request:

  1. Install the latest Gutenberg Nightly.
  2. If needed, restart the Customize Your Store flow by installing the WooCommerce Beta Tester plugin and going to wp-admin/tools.php?page=woocommerce-admin-test-helper > Tools > "Reset Customize Your Store".
  3. Go to WooCommerce > Customize Your Store. Verify there are no errors displayed on the screen.
  4. Smoke test the CYS functionality: change the logo, fonts, colors, some patterns, etc. and save it.
  5. Verify at no moment you see an error and all redirects between screens work as expected.

@Aljullu Aljullu added the focus: customize-your-store Issues related to the Customize Your Store onboarding flow. label Dec 4, 2024
@Aljullu Aljullu self-assigned this Dec 4, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Size Change: +6 B (0%)

Total Size: 4.99 MB

compressed-size-action

@Aljullu Aljullu marked this pull request as ready for review December 4, 2024 08:49
@woocommercebot woocommercebot requested review from a team and octaedro and removed request for a team December 4, 2024 08:50
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024 •
edited
Loading

Hi @octaedro, @gigitux, @mdperez86,

Apart from reviewing the code changes, please make sure to review the testing instructions and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@Aljullu Aljullu requested review from gigitux and mdperez86 December 4, 2024 08:50
@Aljullu Aljullu mentioned this pull request Dec 4, 2024
Closed
8 tasks
@github-actions github-actions bot added the cherry pick to trunk Dev only - Part of CFE, PRR flows label Dec 4, 2024
gigitux
gigitux approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@gigitux gigitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Aljullu Aljullu merged commit e75554e into release/9.5 Dec 4, 2024
46 checks passed
@Aljullu Aljullu deleted the fix/cys-router-9.5 branch December 4, 2024 12:51
github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
@Aljullu
Add new required props to RouterProvider (#53433)
a8e577a 
* Add new required props to RouterProvider

* Add changelog file
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

IMPORTANT: Merging this PR to the appropriate branches is critical to the release process and ensures that the bug does not cause regressions in the future releases.

Cherry picking was successful for trunk. Please merge the following PR: #53444

Aljullu added a commit that referenced this pull request Dec 4, 2024
@github-actions @Aljullu
Cherry pick 53433 into trunk (#53444)
8f72a0a 
Add new required props to RouterProvider (#53433)

* Add new required props to RouterProvider

* Add changelog file

Co-authored-by: Albert Juhé Lluveras <[email protected]>
@jorgeatorres jorgeatorres mentioned this pull request Dec 12, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigitux gigitux gigitux approved these changes

@octaedro octaedro Awaiting requested review from octaedro octaedro was automatically assigned from woocommerce/woo-fse

@mdperez86 mdperez86 Awaiting requested review from mdperez86

Assignees

@Aljullu Aljullu

Labels
cherry pick to trunk Dev only - Part of CFE, PRR flows focus: customize-your-store Issues related to the Customize Your Store onboarding flow. plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aljullu @gigitux