Skip to content
This repository has been archived by the owner on Jun 18, 2022. It is now read-only.

Use remark-language-server #15

Closed
wants to merge 3 commits into from
Closed

Use remark-language-server #15

wants to merge 3 commits into from

Conversation

remcohaszing
Copy link

This adds support for:

  • Formatting using atom-ide-code-format
  • ESM configuration files
  • ESM plugins

I don’t use atom myself nor am I familiar with its plugin API. For me this is mostly a proof of concept to show remark-language-server works for multiple editors.

Closes #14

This adds support for:

- Formatting using atom-ide-code-format
- ESM configuration files
- ESM plugins

Closes #14
@wooorm
Copy link
Owner

wooorm commented Dec 16, 2021

/cc @AlexWayfer

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@AlexWayfer
Copy link

/cc @AlexWayfer

Thank you, but I see a lot of changes, new dependencies, and I'm not too good in Atom Extensions yet, so I trust you.

Or I can just try to check this branch as working.

@wooorm
Copy link
Owner

wooorm commented Jan 2, 2022

I was assuming this was still being worked on, but I guess it isn’t and it’s expected that I instead work on it?

@remcohaszing
Copy link
Author

It’s working, but all tests are broken now. I’m not sure what to test exactly, as all logic happens in the language server. I suppose the exported methods could be tested? Although that doesn’t really assert the plugin works.

@wooorm
Copy link
Owner

wooorm commented Jan 2, 2022

How did you get it to work? It doesn’t work for me? And I’m pretty sure its unifiedjs/unified-language-server#20 that’s blocking?

@remcohaszing
Copy link
Author

At the time of writing I had a lot of linked packages, because some dependencies were unreleased.

I did a bit of cleanup. Now it still just works on my machine.

I think the following steps can be used to start atom with this plugin loaded from this workspace:

npm install
apm link -d
atom --dev .

One simple way to check if it works is to add the following line to a markdown file. This should trigger a warning:

Foo. Bar.

@wooorm
Copy link
Owner

wooorm commented Jan 2, 2022

Are you sure you have the released remark-language-server and unified-language-server (the ones that include plugins: ['remark-parse', ...]?)

Because that doesn’t work on my machine:

Screen Shot 2022-01-02 at 15 17 41

@wooorm
Copy link
Owner

wooorm commented Jan 2, 2022

Do you have remark-parse / remark-stringify installed or linked globally?

@wooorm
Copy link
Owner

wooorm commented Jun 18, 2022

Closing as this package is now deprecated, due to Atom’s own deprecation: https://github.blog/2022-06-08-sunsetting-atom/

@wooorm wooorm closed this Jun 18, 2022
@wooorm
Copy link
Owner

wooorm commented Jun 18, 2022

Closing as this package is now deprecated, due to Atom’s own deprecation: https://github.blog/2022-06-08-sunsetting-atom/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to remark 14?
3 participants