Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FluxC to 1.6.2 #11227

Merged
merged 2 commits into from
Feb 7, 2020
Merged

Update FluxC to 1.6.2 #11227

merged 2 commits into from
Feb 7, 2020

Conversation

mchowning
Copy link
Contributor

Updates the fluxc version in preparation for incorporating Mobile Gutenberg v1.22.0.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@mchowning mchowning added this to the 14.2 milestone Feb 3, 2020
@mchowning mchowning requested review from hypest and marecar3 February 3, 2020 22:02
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 3, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

hypest
hypest reviewed Feb 7, 2020
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
@mchowning
Use FluxC 1.6.1.1
e002c6e 
to avoid bringing in unnecessary changes
@mchowning
Copy link
Contributor Author

👋 @hypest ! Based on our offline discussion, I have created a 1.6.1.1 FluxC release that matches exactly to the hash of fluxc that we were using before.

hypest
hypest approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hypest hypest merged commit 4905ef5 into gutenberg/integrate_release_1.22.0 Feb 7, 2020
@hypest hypest deleted the update_fluxc_to_1.6.2 branch February 7, 2020 17:21
@hypest hypest mentioned this pull request Feb 7, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

@marecar3 marecar3 Awaiting requested review from marecar3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
14.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mchowning @hypest