Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Button block in production #13397

Closed
wants to merge 13 commits into from
Closed

Enable Button block in production #13397

wants to merge 13 commits into from

Conversation

lukewalczak
Copy link
Contributor

@lukewalczak lukewalczak commented Feb 7, 2020 •
edited
Loading

Fixes #

This PR is created only for generating Peril links and testing purposes!

Ref to gb-mobile: wordpress-mobile/gutenberg-mobile#1866

To test:

https://github.com/wordpress-mobile/test-cases/blob/master/test-cases/gutenberg/button.md

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 7, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 22540. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 7, 2020 •
edited
Loading

Warnings
⚠️ This PR is tagged with 'DO NOT MERGE'.
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@lukewalczak lukewalczak changed the base branch from develop to gutenberg/after_1.22.0 February 7, 2020 10:13
@lukewalczak lukewalczak added [Status] DO NOT MERGE Testing Unit and UI Tests and Tooling labels Feb 7, 2020
@lukewalczak lukewalczak mentioned this pull request Feb 7, 2020
Merged
2 tasks
@lukewalczak lukewalczak reopened this Feb 13, 2020
@jkmassel jkmassel deleted the unblock-button branch July 26, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Status] DO NOT MERGE Testing Unit and UI Tests and Tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukewalczak