Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Update React Native dependencies #20774

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented May 31, 2023

In wordpress-mobile/gutenberg-mobile#5789, the React Native dependencies we use in Gutenberg Mobile are updated. This PR updates Podfile.lock to incorporate the version updates.

To test:
The React Native dependencies were updated only for a change in Android, so this PR shouldn't affect the iOS app. Hence, there's nothing to test apart from checking that the build generates successfully.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@fluiddot fluiddot added the Gutenberg Editing and display of Gutenberg blocks. label May 31, 2023
@fluiddot fluiddot added this to the 22.6 milestone May 31, 2023
@fluiddot fluiddot self-assigned this May 31, 2023
@fluiddot fluiddot requested a review from geriux May 31, 2023 10:18
Gutenberg/version.rb Outdated Show resolved Hide resolved
@fluiddot fluiddot force-pushed the gutenberg/update-react-native-deps branch from 1b6b0ac to f8646c9 Compare May 31, 2023 10:24
@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 31, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20774-3308039
Version22.5
Bundle IDorg.wordpress.alpha
Commit3308039
App Center BuildWPiOS - One-Offs #5818
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 31, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20774-3308039
Version22.5
Bundle IDcom.jetpack.alpha
Commit3308039
App Center Buildjetpack-installable-builds #4849
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested these changes using the WordPress app on an iPhone 14 Pro and the editor worked as expected while I was smoke testing it 🚀

@fluiddot fluiddot merged commit ddf53fa into trunk Jun 1, 2023
@fluiddot fluiddot deleted the gutenberg/update-react-native-deps branch June 1, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants