Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image selection from media library #192

Closed
etoledom opened this issue Oct 24, 2018 · 3 comments
Closed

Image selection from media library #192

etoledom opened this issue Oct 24, 2018 · 3 comments
Assignees
Milestone

Comments

@etoledom
Copy link
Contributor

etoledom commented Oct 24, 2018

The image placeholder (or editing an image) should let the user pick an existing image from the media library. We're not dealing with uploads in this issue, those will be in #206

@hypest hypest changed the title Extend communication between RN and Host apps. RN and Host app comm to integrate Image picker and upload Oct 24, 2018
@koke koke added this to the Beta milestone Oct 25, 2018
@koke
Copy link
Member

koke commented Oct 29, 2018

I had this split into two task in the backlog (picker, upload with progress). Do you think it makes sense to split in two, or are they too interrelated?

@koke
Copy link
Member

koke commented Oct 29, 2018

Moved the selection and upload parts to #206

@koke koke changed the title RN and Host app comm to integrate Image picker and upload Image selection from media library Oct 29, 2018
@koke koke modified the milestones: Beta, Alpha Oct 29, 2018
@pinarol pinarol self-assigned this Oct 31, 2018
@koke
Copy link
Member

koke commented Nov 6, 2018

From @etoledom:

This would be the first Image related bridge implementation, so it’s more likely to find unexpected problems. As I see it after experimenting with this topic, the tasks are:

  • Send a message from RN to Native with the Add Image button action.
  • Receive the message in native app.
  • Reuse media picker with to select an image.
  • Send the information of the selected image from Native back to RN.
  • Handle selected image in RN.

In this case, the media picker is already an independent module and it shouldn’t be too complex to implement it in the GutenbergController. Still, we might encounter unexpected challenges.

Estimation: one week per platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants