Image set via parent media library picker #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Wire up the "MEDIA LIBRARY" Image block button * Relay to the parent via the bridge, to launch the media picker * Listen for parent's response * Broadcast an action to set the focused image's URL * Reducer set's the focused image's URL
Which also removes the Store/Reducer action to update the image url. This now gets us closer to the way Gutenberg-web does the update.
hypest
force-pushed
the
feature/embedded-in-parent-app-image-set
branch
from
37497a8 to
2d7a7b6
Compare
4 tasks
|
cc @etoledom as you might want to have a peak at the Bridge change proposal here. Check out https://github.com/wordpress-mobile/gutenberg-mobile/pull/220/files#diff-0ae1e2c19a7a43836c4694c61985e963R6 |
pinarol
approved these changes
Nov 6, 2018
There was a problem hiding this comment.
Tested via WordPress-Android app
- Open a post
- Create image block
- Tap "Media Library"
- Pick an image from WP media library
- Verify that image block is updated with the selected image
- Set a caption for the image
- Repeat these steps multiple times to see if multiple image blocks can be added&updated
|
Using the JS callback looks like a good approach! I checked out the Android side to compare with iOS and it seems like the Media Pickers work in a similar way: providing the selected image via "delegate" callback. So I believe that the WPiOS side implementation will be quite similar too. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #192 for the Android side of the Bridge.
This PR adds a function to the bridge interface to trigger the media library image picker on the parent native app. The function provides a callback for the Bridge to invoke to send the selected image URL back into RN.
Depends on the GB repo PR (needs merge first): WordPress/gutenberg#11511
To test (Android):
feature/integrate-gutenberg-image-setbranch from https://github.com/wordpress-mobile/WordPress-Android. PR here.yarn wpandroidat the wpandroid root to compile the native app, run Metro, install and run the mobile app in a single command