Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the post title in RN. #472

Closed
diegoreymendez opened this issue Jan 14, 2019 · 4 comments
Closed

Implement the post title in RN. #472

diegoreymendez opened this issue Jan 14, 2019 · 4 comments
Assignees
@daniloercoli @diegoreymendez
Labels
[OS] Android [OS] iOS [Type] Enhancement Improves a current area of the editor
Milestone
Beta

Comments

@diegoreymendez
Copy link
Contributor

Description:

Implement the post title in RN.

This task involves:

  • Implementing the logic in gutenberg-mobile to use the post-title component from gutenberg.
  • Create a matching PR in the apps to remove the native title.
  • Make sure edits to the title are properly saved by the apps.
@diegoreymendez diegoreymendez added this to the Beta milestone Jan 14, 2019
@koke
Copy link
Member

koke commented Jan 16, 2019

We already had an issue for this in #372. Can we combine both and make sure we address all the items there? It's fine to break up in multiple tasks/PRs, I just want to make sure we don't forget all those items in #372.

@diegoreymendez
Copy link
Contributor Author

The reason I created this issue was because #372 seems to mention a lot of changes to the title, but not the migration of the title to RN per se.

Should I treat #372 as a master ticket for this one? Should it replace this one?

@daniloercoli daniloercoli assigned daniloercoli and unassigned hypest Jan 17, 2019
@hypest
Copy link
Contributor

hypest commented Jan 21, 2019

372 was superseding this one but was not specific of the implementation change (moving the title into RN). We decided to keep both, rename 372 (already done by Koke) to capture the writing flow details it originally was created for.

@diegoreymendez diegoreymendez mentioned this issue Jan 28, 2019
Merged
@diegoreymendez
Copy link
Contributor Author

Completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniloercoli daniloercoli

@diegoreymendez diegoreymendez

Labels
[OS] Android [OS] iOS [Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
Beta
Development

No branches or pull requests
4 participants
@koke @daniloercoli @hypest @diegoreymendez