Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post title writing flow #372

Closed
9 tasks done
koke opened this issue Dec 13, 2018 · 2 comments
Closed
9 tasks done

Post title writing flow #372

koke opened this issue Dec 13, 2018 · 2 comments
Assignees
Milestone

Comments

@koke
Copy link
Member

koke commented Dec 13, 2018

As part of #182, we added the post title in the apps themselves, which has lead to some issues. For the beta, we'd want:

  • Title should have no border
  • Title shouldn’t be fixed (it should scroll with the content)
  • Title and content should be aware of each other in terms of focus. When the title is selected, the toolbar should only contain global tools (Inserter, Undo/Redo, Hide Keyboard)
  • The "hide keyboard" button should work on the title as well
  • Pressing enter on the title should move to the next block or split a new one if necessary [https://github.com/Handle pressing Enter.key on title in RN #502]
  • Integrate the Noto font and use it on blocks
  • Make sure undo / redo works.
  • The title should be saved in the global store instead of part of AppContainer.js's state.
  • The title placeholder should read "Add a Title". (ref)
@koke koke added this to the Beta milestone Dec 13, 2018
@hypest
Copy link
Contributor

hypest commented Dec 13, 2018

Allow me to add that it would be nice if we could timebox (the least) an experiment around this: render the title inside the RN side, effectively introducing the first mobile non-content block.

@diegoreymendez
Copy link
Contributor

All tasks are completed... this issue will be closed once all PRs are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants