Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant bg color within button appender #1348

Merged
merged 2 commits into from
Sep 4, 2019
Merged

Remove redundant bg color within button appender #1348

merged 2 commits into from
Sep 4, 2019

Conversation

lukewalczak
Copy link
Contributor

Fixes #

To test: WordPress/gutenberg#17325

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@lukewalczak lukewalczak mentioned this pull request Sep 4, 2019
Merged
5 tasks
@pinarol pinarol self-requested a review September 4, 2019 11:44
pinarol
pinarol approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 Feel free to push the merge button after reverting .gitmodules and updating gutenberg to point to rnmobile/master

@pinarol pinarol mentioned this pull request Sep 4, 2019
Closed
@lukewalczak lukewalczak merged commit 6f1647d into develop Sep 4, 2019
@lukewalczak lukewalczak deleted the callstack/rnmobile/bg-color branch September 4, 2019 17:51
daniloercoli added a commit that referenced this pull request Sep 19, 2019
@daniloercoli
Merge branch 'develop' of https://github.com/wordpress-mobile/gutenbe…
dc6feee 
…rg-mobile into add/autosave-monitor

* 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile:
  [iOS]Fix: Oddly formatted text hangs Gutenberg (#1352)
  Remove redundant bg color within button appender (#1348)
  Update bundles
  Update package.json version to 1.12.0

# Conflicts:
#	bundle/android/App.js
#	bundle/android/App.js.map
#	bundle/ios/App.js
#	bundle/ios/App.js.map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

Assignees

@lukewalczak lukewalczak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukewalczak @pinarol