Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg
PR: WordPress/gutenberg#17356Description
This PR allow us to add different styles to DashIcons inside IconButton component depending on the the style theme (Dark/Light mode).
It also enhance the DarkMode theme for Toolbar buttons (and the toolbar separator)
With this change, is not needed to send
ariaPressed
prop fromIconButton
. This is a change that was requested long ago, (even though we still are sending it button states).A second idea is to send styles directly to DashIcon from the Button, to avoid having to declare styles for every new class. I'm not sure if this is something we want to change though.
As always any moment is welcome!
To test:
cc @iamthomasbishop