Fix broken link in Getting Started documentation #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the example unit test link to something not broken. I picked `develop/src/index.test.js` after finding it in a quick search, but let me know if there's a better one to link to!
rachelmcr
approved these changes
Jan 15, 2020
There was a problem hiding this comment.
The tests at /src/index.test.js are the same tests that were previously in /src/app/App.test.js so this looks like a good change to me. 
(Also just want to note I'm aware the Android UI tests are failing in this PR. This PR only has documentation changes so it's fine but if this is a common issue we need to investigate why those failures are happening.)
|
I think the PR needs an update from develop to make the tests pass. But, the changes here are totally not code related so, I'll go ahead and merge them since the PR is otherwise 👍'd. Thanks! |
This was referenced Feb 3, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the example unit test link to something not broken.
I picked
develop/src/index.test.jsafter finding it in a quick search, but let me know if there's a better one to link to!To test: review README.md.
Update release notes:
RELEASE-NOTES.txt.