Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding retry feature to mobile apiFetch handler #1686

Merged
merged 8 commits into from
Jan 31, 2020
Merged

Adding retry feature to mobile apiFetch handler #1686

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5b1872d
Adding retry feature to mobile apiFetch handler
etoledom Dec 16, 2019
a5e9eea
Add Android Native handling of http error codes for failed requests
mchowning Dec 19, 2019
8ff8d15
Merge remote-tracking branch 'origin/develop' into issue/network-retry
mchowning Dec 20, 2019
9b048aa
Update Android errors to use Bundle instead of Map
mchowning Dec 20, 2019
751e581
Pretty print errors
mchowning Dec 20, 2019
cb41c2e
Merge remote-tracking branch 'origin/develop' into issue/network-retry
mchowning Jan 28, 2020
06fd3eb
Adding delay to retry network call if a unknown error is encountered.
etoledom Jan 30, 2020
5ee454d
Returning error directly in case of a known HTTP error occours
etoledom Jan 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/api-fetch-setup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ import { fetchRequest } from 'react-native-gutenberg-bridge';
*/
import apiFetch from '@wordpress/api-fetch';

const fetchHandler = ( { path } ) => {
const setTimeoutPromise = ( delay ) => new Promise( ( resolve ) => setTimeout( resolve, delay ) );

const fetchHandler = ( { path }, retries = 20 ) => {
if ( ! isPathSupported( path ) ) {
return Promise.reject( `Unsupported path: ${ path }` );
}
Expand All @@ -27,7 +29,12 @@ const fetchHandler = ( { path } ) => {
return responsePromise.then( parseResponse ).catch( ( error ) => {
// eslint-disable-next-line no-console
console.warn( 'Network Error: ', error );
return Promise.resolve( error );
if ( error.code >= 400 && error.code < 600 ) {
return Promise.reject( error );
} else if ( retries === 0 ) {
return Promise.reject( error );
}
return setTimeoutPromise( 2000 ).then( () => fetchHandler( { path }, retries - 1 ) );
} );
};

Expand Down