Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode Android RN version in bridge and aztec #1786

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Jan 20, 2020

Before this fix, building the Android react-native-gutenberg-bridge or react-native-aztec modules directly (i.e., where they are the rootProject) would use an older version of react native. With a recent change to the project this resulted in a build error. Jitpack builds those modules directly, so builds on Jitpack were failing.

This is a temporary fix to get the Jitpack builds back to green while I work on a solution that doesn't use hardcoded values. I expect to open a new PR with a cleaner solution later today.

I'm not updating the value in the relevant package.json files in this temporary-fix-PR because it seems that we need version v0.60.0-patched in the package.json files, but we need to drop the v for the java dependency version.

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

react-native-aztec

This is a temporary fix to get the Jitpack builds back to green while I
work on a solution that doesn't use hardcoded values.
@mchowning mchowning added the [Type] Bug Something isn't working label Jan 20, 2020
@mchowning mchowning added this to the 1.21 milestone Jan 20, 2020
@mchowning mchowning changed the title Hardcode Android RN version in react-native-gutenberg-bridge and Hardcode Android RN version in bridge and aztec Jan 20, 2020
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the example app and WordPress Android app build locally with this change, and noted the successful green build on jitpack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[OS] Android [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants