Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ref to react-native-slider fork to support autolinking #1826

Merged
merged 3 commits into from
Jan 29, 2020

Conversation

lukewalczak
Copy link
Contributor

@lukewalczak lukewalczak commented Jan 28, 2020

Fixes app crash on opening settings within Spacer, because of missing RNCSlider after updating RN.

During the building process you could notice a warning:

[!] use_native_modules! skipped the react-native dependency '@react-native-community/slider'. No podspec file was found.

I assume that autolinking requires podspec file to be on the project root, but in react-native-slider is nested so I had to move up.

To test:

  1. remove old node_modules
  2. yarn clean:install
  3. yarn ios
  4. add a Spacer block
  5. open settings
  6. app mustn't crash!

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@lukewalczak lukewalczak force-pushed the update/react-native-slider branch from 5ec78eb to fa58081 Compare January 28, 2020 19:05
@lukewalczak lukewalczak force-pushed the update/react-native-slider branch from 8bffb16 to 0a04f4f Compare January 28, 2020 19:30
Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for taking care of this!

As a helpful note to others, I was getting a CocoaPods error, and I had to clear my Derived Data as well.

@lukewalczak lukewalczak force-pushed the update/react-native-slider branch from 0a04f4f to 2c4e38a Compare January 28, 2020 19:50
@lukewalczak lukewalczak merged commit d87988e into develop Jan 29, 2020
@lukewalczak lukewalczak deleted the update/react-native-slider branch January 29, 2020 08:54
@mkevins mkevins restored the update/react-native-slider branch February 3, 2020 00:55
@mkevins mkevins deleted the update/react-native-slider branch July 6, 2020 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants