Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make inserter to show options on long-press to add before/after #1835

Merged
merged 20 commits into from
Jan 30, 2020
Merged

Make inserter to show options on long-press to add before/after #1835

merged 20 commits into from
Jan 30, 2020

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Jan 29, 2020 •
edited
Loading

Fixes #1433

To test: see Gutenberg PR: WordPress/gutenberg#18791

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

ceyhun added 20 commits December 3, 2019 23:05
@ceyhun
Change gutenberg submodule url to forked repo
8881484
@ceyhun
Update gutenberg ref
e91601d
@ceyhun
Update release notes
dbf97eb
@ceyhun
Wrap jest.runAllTicks in a separate "act"
8f40416
@ceyhun
Merge branch 'develop' into issue/1433-long-press-on-inserter-to-show…
fc8c277 
…-add-before-after
@ceyhun
Merge branch 'develop' into issue/1433-long-press-on-inserter-to-show…
5780b5c 
…-add-before-after
@ceyhun
Update gutenberg ref
d327990
@ceyhun
Merge branch 'develop' into issue/1433-long-press-on-inserter-to-show…
66dce8e 
…-add-before-after
@ceyhun
Update release notes
faeb565
@ceyhun
Update gutenberg ref
e193c61
@ceyhun
Update gutenberg ref
950858d
@ceyhun
Merge branch 'develop' into issue/1433-long-press-on-inserter-to-show…
bcd864a 
…-add-before-after
@ceyhun
Update gutenberg ref
584d64b
@ceyhun
Merge branch 'develop' into issue/1433-long-press-on-inserter-to-show…
cb685c9 
…-add-before-after
@ceyhun
Update release notes
f58d8ea
@ceyhun
Update gutenberg ref
a6266d1
@ceyhun
Merge branch 'develop' into issue/1433-long-press-on-inserter-to-show…
dd8e5d2 
…-add-before-after
@ceyhun
Merge branch 'develop' into issue/1433-long-press-on-inserter-to-show…
74a3218 
…-add-before-after
@ceyhun
Update gutenberg ref
bba6f28
@ceyhun
Update gutenberg ref
7c34543
@ceyhun ceyhun changed the title Issue/1433 long press on inserter to show add before after Make inserter to show options on long-press to add before/after Jan 29, 2020
@ceyhun ceyhun mentioned this pull request Jan 29, 2020
Closed
1 task
@ceyhun ceyhun requested a review from SergioEstevao January 29, 2020 16:24
@ceyhun ceyhun added this to the 1.22 milestone Jan 29, 2020
SergioEstevao
SergioEstevao approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good thanks for this change!

@ceyhun ceyhun merged commit 28f7f7e into develop Jan 30, 2020
@ceyhun ceyhun deleted the issue/1433-long-press-on-inserter-to-show-add-before-after branch January 30, 2020 12:15
This was referenced Feb 3, 2020
Merged
Merged
Merged
@iamthomasbishop iamthomasbishop mentioned this pull request Feb 12, 2020
Merged
@designsimply
Copy link
Contributor

Looks lovely! 😍

Screenshot_20200221-160053

Tested with WPAndroid 14.2-rc-2 on Pixel 3 Android 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.

Proposal: Long-press on inserter to show options for "add above" and "add below"
3 participants
@ceyhun @designsimply @SergioEstevao