Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DEV flag from Media Editor button #1847

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Remove DEV flag from Media Editor button #1847

merged 1 commit into from
Jan 31, 2020

Conversation

leandroalonso
Copy link
Contributor

Remove the __DEV__ flag so the Media Editor button will be available for iOS in production too.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@leandroalonso leandroalonso added this to the 1.22 milestone Jan 31, 2020
@leandroalonso leandroalonso self-assigned this Jan 31, 2020
etoledom
etoledom approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: !

@leandroalonso leandroalonso merged commit b7ffa8c into develop Jan 31, 2020
@leandroalonso leandroalonso deleted the issue/1583_remove_dev_flag_from_media_edit_button branch January 31, 2020 14:52
This was referenced Feb 3, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

Assignees

@leandroalonso leandroalonso

Labels
Media [Type] Task
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
2 participants
@leandroalonso @etoledom