Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gallery upload options in production #1855

Merged
merged 11 commits into from
Feb 13, 2020

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Feb 5, 2020

Fixes #1610

Sibling PRs

Description

This PR enables gallery block upload options in production (on mobile).

Reviewing

Generating bundles results in a large diff due to this recent change. The relevant diff for this PR is here and also the gutenberg reference update.

To test: #1610 (comment)

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subfolders in bundle/android/* and bundle/ios/* Where previously added and then removed again in here

Sorry if this is a basic question, what's the reason for re-adding them here?

@mkevins
Copy link
Contributor Author

mkevins commented Feb 10, 2020

Hi @chipsnyder 👋

The subfolders in bundle/android/* and bundle/ios/* Where previously added and then removed again in here

Sorry if this is a basic question, what's the reason for re-adding them here?

There are a couple things going on here, I'll try to clarify:

The removal you mention is part of #1844 to revert commits accidentally pushed directly to develop.

The bundles added here are only for the purpose of generating WordPress-Android and WordPress-iOS builds on CI, and can be reverted before this PR is merged.

Let me know if this helps.

@chipsnyder
Copy link
Contributor

Yup, that clears it up! Thanks @mkevins

@mkevins mkevins marked this pull request as ready for review February 11, 2020 08:04
Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved with #1610 (comment)

Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkevins mkevins merged commit 6352c21 into develop Feb 13, 2020
@mkevins mkevins deleted the feature/gallery-upload-options branch February 13, 2020 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Media [Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile gallery block - Upload options
3 participants