-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable gallery upload options in production #1855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The subfolders in bundle/android/*
and bundle/ios/*
Where previously added and then removed again in here
Sorry if this is a basic question, what's the reason for re-adding them here?
Hi @chipsnyder 👋
There are a couple things going on here, I'll try to clarify: The removal you mention is part of #1844 to revert commits accidentally pushed directly to The bundles added here are only for the purpose of generating WordPress-Android and WordPress-iOS builds on CI, and can be reverted before this PR is merged. Let me know if this helps. |
Yup, that clears it up! Thanks @mkevins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Approved with #1610 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Approved by WordPress/gutenberg#20043 (review)
Fixes #1610
Sibling PRs
gutenberg
: [Mobile] Enable gallery upload options in production WordPress/gutenberg#20043WordPress-Android
: Enable gallery upload options in production WordPress-Android#11234WordPress-iOS
: Enable gallery upload options in production WordPress-iOS#13374Description
This PR enables gallery block upload options in production (on mobile).
Reviewing
Generating bundles results in a large diff due to this recent change. The relevant diff for this PR is here and also the
gutenberg
reference update.To test: #1610 (comment)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.