Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fix [Obj] character after dictation #1969

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Feb 28, 2020

This PR fixes an issue where an unwanted character was inserted after dictation.

And also, now dictations on the middle of the string will be positioned correctly (not always at the end).

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@etoledom etoledom added this to the 1.24 milestone Feb 28, 2020
@etoledom etoledom self-assigned this Feb 28, 2020
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great! :shipit:

@etoledom etoledom merged commit da4bf02 into develop Feb 28, 2020
@etoledom
Copy link
Contributor Author

Thank you! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants