Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Aztec send height information to JS after pasting text #481

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Jan 21, 2019

Fixes #438

This is a small PR that forces layout when the user paste text. I noticed that layoutSubviews is called every time textViewDidChange is called, except for pasted text. Adding an explicit call to setNeedsLayout() solves the issue.

I tested that layoutSubviews is not called more than once for every text change, and now it's properly called after pasting text.

pasting

To test:

  • Test pasting a long text in a paragraph block.
  • Check that its heights grows accordingly.

@etoledom etoledom added the Paste label Jan 21, 2019
@etoledom etoledom added this to the Beta milestone Jan 21, 2019
@etoledom etoledom self-assigned this Jan 21, 2019
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@etoledom etoledom merged commit b643c27 into develop Jan 24, 2019
@etoledom
Copy link
Contributor Author

Thank you!

@etoledom etoledom deleted the issue/438-pasting-block-height-ios branch January 24, 2019 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants