-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.81.1 #5119
Release 1.81.1 #5119
Conversation
Writing Flow checklist (iOS) 🟢Build: pr19238-854c1ae General
Rich Text Format
Splitting and merging
Undo / Redo - Test Cases |
New Changes (iOS) 🟢Build: pr19238-854c1ae
|
🟢 Writing Flow checklist (Android)Build: pr17090-56c9c96 General
Rich Text Format
Splitting and merging
Undo / Redo - Test Cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊 !
--- | ||
* [*] List block v2: Fix text color inconsistencies with list items [https://github.com/wordpress-mobile/gutenberg-mobile/pull/5096] | ||
* [*] Use default placeholder text color for native List Item [https://github.com/WordPress/gutenberg/pull/43353] | ||
* [*] Add BlockListCompact [https://github.com/WordPress/gutenberg/pull/43431] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: I noticed that this entry in the React Native editor's changelog has two **
(reference).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the release tag was already created, I'd update this in a different PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! 😅 I'll update it once I start merging back to trunk
👍
* [*] Use default placeholder text color for native List Item [https://github.com/WordPress/gutenberg/pull/43353] | ||
* [*] Add BlockListCompact [https://github.com/WordPress/gutenberg/pull/43431] | ||
* [*] Fix dynamic React Native version [https://github.com/WordPress/gutenberg/pull/43058] | ||
* [*] Disable FastImage on Android [https://github.com/wordpress-mobile/gutenberg-mobile/pull/5102] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: I noticed that this entry in the React Native editor's changelog has two **
(reference).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the release tag was already created, I'd update this in a different PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update it, thanks for catching that!
# Conflicts: # bundle/ios/App.js # bundle/ios/App.js.map # gutenberg
Additional |
Waiting to merge WordPress/gutenberg#43612 so CI checks can pass. |
src/test/index.js
Outdated
@@ -106,14 +106,13 @@ describe( 'Gutenberg Mobile initialization', () => { | |||
{ locale: defaultLocale, capabilities }, | |||
{ component: EditorComponent } | |||
); | |||
const blockList = screen.getByTestId( 'block-list-wrapper' ); | |||
// Inner blocks create BlockLists so let's take into account selecting the main one | |||
const blockList = screen.getAllByTestId( 'block-list-wrapper' )[0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes were already introduced in the Gutenberg repo.
Release for Gutenberg Mobile 1.81.1
Related PRs
Extra PRs that Landed After the Release Was Cut
No extra PRs yet. 🎉
Changes
List block v2: Fix text color inconsistencies with list items
Use default placeholder text color for native List Item
Add BlockListCompact
Disable FastImage on Android
Fix dynamic React Native version
Test plan
Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.
Release Submission Checklist
RELEASE-NOTES.txt
is updated with all the changes that made it to the release. ReplaceUnreleased
section with the release version and create a newUnreleased
section.gutenberg/packages/react-native-editor/CHANGELOG.md
is updated with all the changes that made it to the release. Replace## Unreleased
with the release version and create a new## Unreleased
.