Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile] - Block selection - Expand tapping on nested blocks directly #5781

Merged
merged 13 commits into from
May 18, 2023
Merged

[Mobile] - Block selection - Expand tapping on nested blocks directly #5781

merged 13 commits into from
May 18, 2023

Conversation

wpmobilebot
Copy link
Collaborator

@wpmobilebot wpmobilebot commented May 16, 2023 •
edited by geriux
Loading

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 16, 2023 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux geriux mentioned this pull request May 16, 2023
Merged
@geriux geriux force-pushed the version-toolkit/gutenberg/rnmobile/expand-tapping-on-nested-blocks-directly branch from 51c60f2 to 2d14b43 Compare May 17, 2023 13:39
@geriux geriux self-assigned this May 17, 2023
@geriux geriux requested a review from dcalhoun May 17, 2023 15:15
@geriux geriux added this to the 1.96.0 (22.5) milestone May 17, 2023
dcalhoun
dcalhoun approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice improvement for block selection to align more closely with the web editor. We should likely add a release note for this change. 🚀

Also, there are several other tests that rely upon "Navigate Up." Should leave them as-is or attempt to refactor them?

@geriux geriux force-pushed the version-toolkit/gutenberg/rnmobile/expand-tapping-on-nested-blocks-directly branch from 2d14b43 to 2d2254f Compare May 18, 2023 11:00
dcalhoun
dcalhoun reviewed May 18, 2023
View reviewed changes
RELEASE-NOTES.txt Outdated Show resolved Hide resolved
RELEASE-NOTES.txt Outdated Show resolved Hide resolved
RELEASE-NOTES.txt Outdated Show resolved Hide resolved
Gerardo and others added 5 commits May 18, 2023 14:39
Update Gutenberg ref
7f97906
E2E Tests - Use the recursive option for the navigateUp helper
c842b09
@dcalhoun
Update RELEASE-NOTES.txt
df2bdce 
Co-authored-by: David Calhoun <[email protected]>
@dcalhoun
Update RELEASE-NOTES.txt
9c0c6cd 
Co-authored-by: David Calhoun <[email protected]>
Merge branch 'version-toolkit/gutenberg/rnmobile/expand-tapping-on-ne…
001c47b 
…sted-blocks-directly' of github.com:wordpress-mobile/gutenberg-mobile into version-toolkit/gutenberg/rnmobile/expand-tapping-on-nested-blocks-directly
@geriux geriux mentioned this pull request May 18, 2023
Merged
@geriux geriux merged commit 5267a0f into trunk May 18, 2023
@geriux geriux deleted the version-toolkit/gutenberg/rnmobile/expand-tapping-on-nested-blocks-directly branch May 18, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees

@geriux geriux

Labels
None yet
Projects
None yet
Milestone
1.96.0 (22.5)
Development

Successfully merging this pull request may close these issues.
3 participants
@wpmobilebot @dcalhoun @geriux