Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.99.1 #5962

Merged
merged 9 commits into from
Jul 17, 2023
Merged

Release 1.99.1 #5962

merged 9 commits into from
Jul 17, 2023

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jul 13, 2023

Release for Gutenberg Mobile 1.99.1

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Fix crash related to removing a block under certain conditions

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

@fluiddot
Copy link
Contributor Author

fluiddot commented Jul 14, 2023

🟢 Writing Flow (iOS)

Build: pr21098-f41da0d
Device: iPhone 11 (iOS 15.4.1)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC007 - Test format detection under the cursor
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading

Undo / Redo - Test Cases

@fluiddot
Copy link
Contributor Author

fluiddot commented Jul 14, 2023

🟢 Release Changes (iOS)

Build: pr21098-f41da0d
Device: iPhone 11 (iOS 15.4.1)

@fluiddot
Copy link
Contributor Author

fluiddot commented Jul 14, 2023

🟢 Writing Flow (Android)

Build: pr18772-dd0a7f6
Device: Samsung Galaxy S20 FE 5G (Android 13)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading

Undo / Redo - Test Cases

@fluiddot
Copy link
Contributor Author

fluiddot commented Jul 14, 2023

🟢 Release Changes (Android)

Build: pr18772-dd0a7f6
Device: Samsung Galaxy S20 FE 5G (Android 13)

@fluiddot fluiddot marked this pull request as ready for review July 14, 2023 08:42
@SiobhyB SiobhyB self-requested a review July 14, 2023 08:56
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#52611 (review)

Note: I've re-run the failed iOS test on this PR, as it looks to have failed due to flakiness.

fluiddot added 2 commits July 14, 2023 17:56
# Conflicts:
#	bundle/ios/App.js
#	bundle/ios/App.js.map
#	gutenberg
@fluiddot fluiddot enabled auto-merge July 14, 2023 16:08
@fluiddot
Copy link
Contributor Author

fluiddot commented Jul 17, 2023

The recent failure in the CI job Check Correctness will be fixed via #5967. In the meantime, I cherry-picked the fix (827b8cf) to confirm it addresses the failure.

@fluiddot fluiddot merged commit 75e94d5 into trunk Jul 17, 2023
@fluiddot fluiddot deleted the release/1.99.1 branch July 17, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants