Fix/Set focus on title for new posts on Android #611
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes wordpress-mobile/WordPress-iOS#10594 for Android.
Initially we've made a fully JS version of it here, but does't seem to work fine on Android, due to probably the way Android handle the focus.
I've spent some hrs trying to fix the issue on the Android side (native) without much luck, then added to the bridge the ability to send an event
focus on title
and used it in the android app.In this PR we wait until the editor is mounted, listen for
editorDidMount
, and emit an event to set the focus on title when both content and title are empty.Test 1
wp-android
Test 2
Not sure if something is required on the iOS side. Tests are passing.