GutenbergDemo app: Enable Hermes #6154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
1 similar comment
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
geriux
force-pushed
the
update-demo-app-hermes
branch
3 times, most recently
from
5243a92 to
75c35ab
Compare
geriux
force-pushed
the
update-demo-app-hermes
branch
4 times, most recently
from
5d62af2 to
1cc16a1
Compare
geriux
force-pushed
the
update-demo-app-hermes
branch
from
1cc16a1 to
f171667
Compare
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
This PR enables Hermes in the Demo app.
It removes the usage of
test:e2e:bundle:iosin favor of using the command from Gutenbergnpm run core test:e2e:bundle:iosthis way we only need to keep updated in one place.Due to using Hermes on iPad the visual E2E tests were loading a very large test content which was affecting the stability of the test so I updated it to just have the content the test needed.
Lastly, it updates a visual snapshot for the Unsupported block editor.
To test CI checks should pass, including Full E2E tests.
PR submission checklist: