"Add Block" icon color

[etoledom]

fixes: #546

This PR implements the changes made in WordPress/gutenberg#14631 to change the default color of Dashicons (in this case on ToolbarButton).

To test:

• Build the app.
• Check that the add-block button is filled with $blue-wordpress color.

[iamthomasbishop]

Is this using a Dashicon? If so, can we either use a custom SVG or Material icon here? This icon feels a little off.

[etoledom]

Is this using a Dashicon? If so, can we either use a custom SVG or Material icon here? This icon feels a little off.

Yes it is Dashicon. The ToolbarButton component is made on top of Dashicon component.
We can have a custom SVG, we did it before for the hide-keyboard icon. But it's kinda hacky 🤔

If the previous icon looks better compared to this one, maybe we can wait a bit for this change?

[Tug]

We shouldn't be setting the icon's color attribute as it will be prone to error if we add css rules to this addBlockButton class. Also it's best practice to group styling in style or className.
So:

extraProps={ { style: styles.addBlockButton } }

[etoledom]

Thanks @Tug and @iamthomasbishop for the review!

I implemented the suggested changes and tweaked a bit the look of the icon as Thomas suggested, adding a border to it. Now it looks 😎

[iamthomasbishop]

That looks so much better. Thank you! <3

[Tug]

LGTM 👍

[etoledom]

Updated with the changes requested for a better clarity on the intention.
Thank you @Tug !

[etoledom]

I updated the implementation of this, with a new gutenberg side PR: WordPress/gutenberg#14631

Would you mind @Tug taking another look?
Thank you!

[Tug]

Works well, good job here 🎉

[etoledom]

Thank you!