-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update npm config with fetch-retry-mintimeout
and fetch-retry-maxtimeout
#6698
Conversation
fetch-retry-mintimeout
and fetch-retry-maxtimeout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geriux I'm curious about how the timeout error would be addressed by increasing fetch-retry-mintimeout
and fetch-retry-maxtimeout
. As far as I checked the documentation, these parameters are used to wait for retrying fetching a package. The increase implies more retries based on the default factor (10). Per the retry
module documentation , the timeout is calculated with the following formula.
Math.min(random * minTimeout * Math.pow(factor, attempt), maxTimeout)
That said, I wonder if instead of increasing the timeouts of retries, we could simply increase the request timeout (fetch-timeout
). WDYT?
From your comment, I tried that in #6699 and it doesn't work for our issues. When looking for solutions, the most mentioned approaches were to increase It appears that |
I'm going to retry all jobs again just to make sure they pass the |
Some of the jobs will fail due to the existing artifacts in CI. I think we could try this approach and see how it performs. What do you think @fluiddot ? |
Sounds good, the changes won't break the CI jobs so let's try it. |
c9405d4
to
39ed993
Compare
Ok it is still failing 😅 . We should probably fix the CI issues by adding cache to see if it solves this npm failures. I'll close this for now. |
@geriux Another option we could try is to reduce the number of parallel connections with |
Interesting, let's try that! |
Seems changing maxsockets didn't address the issue 😞. At this point, I think we should investigate the Buildkite instance to avoid connection timeouts. |
Yup, I'm trying one more thing just out of curiosity which is to remove the |
This PR attempts to solve the current errors when installing
npm
dependencies in CI, mostly happening in the Android jobs with the error:It increases the following config:
fetch-retry-mintimeout
to120000
fetch-retry-maxtimeout
to300000
For comparison in my local setup, the default values are
10000
forfetch-retry-mintimeout
and60000
forfetch-retry-maxtimeout
To test all CI checks should pass.
PR submission checklist: