Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react-native-webview to version 11.26.1 #20

Merged
merged 1 commit into from
May 19, 2023

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented May 19, 2023

After upgrading the libraries to use Android API 33, the library react-native-webview couldn't be published due to a build error (reference):

/workdir/node_modules/react-native-webview/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java:275: error: cannot find symbol
        view.getSettings().setAppCachePath(ctx.getCacheDir().getAbsolutePath());
                          ^
  symbol:   method setAppCachePath(String)
  location: class WebSettings
/workdir/node_modules/react-native-webview/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java:277: error: cannot find symbol
        view.getSettings().setAppCacheEnabled(true);
                          ^
  symbol:   method setAppCacheEnabled(boolean)
  location: class WebSettings
/workdir/node_modules/react-native-webview/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java:281: error: cannot find symbol
      view.getSettings().setAppCacheEnabled(false);
                        ^
  symbol:   method setAppCacheEnabled(boolean)
  location: class WebSettings
/workdir/node_modules/react-native-webview/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java:475: error: cannot find symbol
    view.getSettings().setAppCacheEnabled(false);
                      ^
  symbol:   method setAppCacheEnabled(boolean)
  location: class WebSettings

On Android 13, setAppCacheEnabled function is deprecated. This was already solved in the library (react-native-webview/react-native-webview#2547), so we can simply bump the library to the latest 11 version to address the issue. Seems there are no breaking changes between 11.6.2 to 11.26.1.

NOTE: As mentioned here, we keep using version 11 as version 12 is not working properly.

@fluiddot fluiddot requested a review from geriux May 19, 2023 10:30
@fluiddot fluiddot self-assigned this May 19, 2023
Copy link

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fluiddot fluiddot merged commit 13f119d into trunk May 19, 2023
@fluiddot fluiddot deleted the bump-react-native-webview-11.26.1 branch May 19, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants