Skip to content

Commit

Permalink
add FIXME on libcxx check
Browse files Browse the repository at this point in the history
Signed-off-by: onur-ozkan <[email protected]>
  • Loading branch information
onur-ozkan committed May 28, 2024
1 parent 480670e commit dd24a11
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions src/bootstrap/src/core/sanity.rs
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ pub fn check(build: &mut Build) {
}

// Ensure that a compatible version of libstdc++ is available on the system when using `llvm.download-ci-llvm`.
if !build.config.dry_run() && !build.build.is_msvc() && build.config.llvm_from_ci {
if !build.config.dry_run() && build.config.llvm_from_ci {
let builder = Builder::new(build);
let libcxx_version = builder.ensure(tool::LibcxxVersionTool { target: build.build });

Expand All @@ -124,11 +124,7 @@ pub fn check(build: &mut Build) {
}
}
tool::LibcxxVersion::Llvm(_) => {
eprintln!(
"\nYour system is using libc++, which is incompatible with the `llvm.download-ci-llvm` option."
);
eprintln!("Disable `llvm.download-ci-llvm` or switch to libstdc++.");
crate::exit!(1);
// FIXME: Handle libc++ version check.
}
}
}
Expand Down

0 comments on commit dd24a11

Please sign in to comment.