Add theme status in wp theme get command
#177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrijith
reviewed
May 22, 2019
There was a problem hiding this comment.
Thanks for the PR @sagarnasit !
Could please add tests for this change?
|
@thrijith added a behat test |
thrijith
reviewed
May 23, 2019
There was a problem hiding this comment.
@sagarnasit, Thanks for the PR !
I've added a few comments regarding the tests, rest LGTM, I think it should also contain one test for wp theme get p2 with status row in it.
|
@thrijith Added changes you asked. |
thrijith
reviewed
May 25, 2019
|
Not sure why the build is failing, It seems unrelated to this PR. |
|
@sagarnasit Can you merge/rebase latest master? I think the test failure should be fixed now. |
schlessera
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add theme status filed for
wp theme getcommand.Fixes #172