Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add behat tests for install-wp-tests.sh #37

Merged
merged 6 commits into from
Aug 8, 2017
Merged

add behat tests for install-wp-tests.sh #37

merged 6 commits into from
Aug 8, 2017

Conversation

miya0001
Copy link
Member

@miya0001 miya0001 commented Aug 8, 2017

Add behat tests for templates/install-wp-tests.sh.

There are 3 scenarios.

  • Usage should be displayed.
  • Installs latest version of the WordPress.
  • Installs WordPress 3.7.

@miya0001
Copy link
Member Author

miya0001 commented Aug 8, 2017

Related: #35

@miya0001 miya0001 mentioned this pull request Aug 8, 2017
Merged
@miya0001 miya0001 requested review from a team and removed request for a team August 8, 2017 10:43
@miya0001
Copy link
Member Author

miya0001 commented Aug 8, 2017

Ah, I want to improve those tests to run phpunit.

@danielbachhuber
Copy link
Member

Great work on this @miya0001 — thanks for taking the initiative.

@miya0001
Copy link
Member Author

miya0001 commented Aug 8, 2017 •
edited
Loading

I finished to develop it.

There are 3 scenarios:

  • Run install-wp-tests.sh with latest, then check the files should exist as expected and run phpunit.
  • Run install-wp-tests.sh with trunk, then check the files should exist as expected and run phpunit.
  • Run install-wp-tests.sh with 3.7, then check the files should exist as expected. But phpunit isn't executed because older version of WordPress or WP_UnitTestCase does't have compatiblity with PHP 7.1 or PHP 7.

@miya0001 miya0001 requested a review from a team August 8, 2017 14:40
@danielbachhuber danielbachhuber added this to the 1.0.6 milestone Aug 8, 2017
@danielbachhuber danielbachhuber merged commit 2e6f08b into wp-cli:master Aug 8, 2017
@danielbachhuber danielbachhuber mentioned this pull request Aug 22, 2017
Closed
danielbachhuber added a commit that referenced this pull request Nov 18, 2022
@danielbachhuber
Merge pull request #37 from miya0001/add-tests-for-install-wp-tests
2134557 
add behat tests for install-wp-tests.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees
No one assigned
Labels
command:scaffold command:scaffold-plugin-tests
Projects
None yet
Milestone
1.0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@miya0001 @danielbachhuber