-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to Linux #3
Conversation
– starts a stream of the entire screen – starts a `MediaRecorder` session that captures such stream - returns an URL to the stream
and the ffmpeg bin is freaking huge
This can easily be ported to Mac, replacing all of the Swift code. The changes we'd need to make to the bash script are here: https://trac.ffmpeg.org/wiki/Capture/Desktop#OSX |
@PaulBGD thank you for the PR! I'm afraid we can't use Recording the entire screen with Recording the entire screen with Besides that, we can't record a section of the screen with It would be awesome if you could gather some benchmarks from |
Yeah we could do it native, but ffmpeg is incredibly fast on Linux. I'll grab some benchmarks. |
Yo @PaulBGD, I'm curious about those benchmarks - have you had any time to run any? 😅 |
ffmpeg could record 345 frames using 1 CPU core, recordMyDesktop could barely record 60 using the same core. From what I can tell its because rMD uses a custom encoder that is nowhere as fast as ffmpeg. With the time that we'd have to put in to make a native implementation as fast as ffmpeg ourselves, I think ffmpeg is the better choice. |
This is ready to go! |
If you want to test it, just run ./linux/capture.sh with the same arguments that you'd pass to the swift binary.