New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing dependency #17

Merged

sindresorhus merged 1 commit into wulkano:main from kyleshay:delaydep

Mar 18, 2021

Contributor

kyleshay commented Mar 17, 2021 •

edited

Loading

Because the new delay dep is in the devDependencies, it's possible that it might not get loaded in.

Edit, for some additional context: Looks like delay was previously just being used for the example/test files. It's now being used in index.js:
https://github.com/wulkano/aperture-node/pull/14/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R202

other option could be to re-use the same sort of logic in start() with resolving in a setTimeout


          Move the delay dependency to dependencies

0881a80

sindresorhus changed the title ~~Move the delay dependency to dependencies~~ Fix missing dependency

sindresorhus merged commit 7b3125a into wulkano:main

kyleshay deleted the delaydep branch

March 18, 2021 16:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet