Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Use Drupal core Scaffold Composer plugin. #77

Closed
wants to merge 5 commits into from

Conversation

tormi
Copy link
Member

@tormi tormi commented Oct 8, 2019

@tormi tormi requested a review from floretan October 8, 2019 19:04
@greg-1-anderson
Copy link
Contributor

Caution: see https://www.drupal.org/project/drupal/issues/3086148

The name of the scaffold metadata key in the composer.json extra section might change this week. Friday is the code freeze, so whatever is in at that point will be stable.

@greg-1-anderson
Copy link
Contributor

See drupal-composer/drupal-project#522 (comment); all builds for Drupal 8.7.x and earlier will fail for a time.

@tormi tormi changed the title Use Drupal core Scaffold Composer plugin. WIP: Use Drupal core Scaffold Composer plugin. Oct 8, 2019
@tormi
Copy link
Member Author

tormi commented Oct 8, 2019

Thanks, Greg!

@tormi tormi force-pushed the feature/drupal-core-scaffold-composer-plugin branch from 9702a8b to 5a8f054 Compare October 31, 2019 16:40
@tormi tormi force-pushed the feature/drupal-core-scaffold-composer-plugin branch from 1b672ec to 17875b7 Compare November 2, 2019 19:43
@tormi
Copy link
Member Author

tormi commented Nov 2, 2019

The reason for f6a861e:

#!/bin/bash -eo pipefail
if [ -f phpcs.xml ] && [ -f vendor/bin/phpcs ]; then
  vendor/bin/phpcs --standard=phpcs.xml -s --colors
fi

FILE: /home/circleci/project/autoload.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 8 | ERROR | [x] Expected 1 space after asterisk; 0 found
   |       |     (Drupal.Commenting.DocCommentAlignment.NoSpaceAfterStar)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 2.58 secs; Memory: 12MB

Exited with code 2

@tormi
Copy link
Member Author

tormi commented Nov 5, 2019

Palantir's template maintainer's thread about the issue: https://drupal.slack.com/archives/C392CHBEW/p1572892152053100

@tormi
Copy link
Member Author

tormi commented Nov 5, 2019

@tormi tormi force-pushed the feature/drupal-core-scaffold-composer-plugin branch from 9fce24b to e8c4d94 Compare December 4, 2019 20:33
@tormi
Copy link
Member Author

tormi commented Dec 6, 2019

Closing in favour of #89.

@tormi tormi closed this Dec 6, 2019
@tormi tormi deleted the feature/drupal-core-scaffold-composer-plugin branch December 6, 2019 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants