Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add empty defaultProps declaration snippet #35

Merged
merged 3 commits into from
Nov 13, 2017
Merged

add empty defaultProps declaration snippet #35

merged 3 commits into from
Nov 13, 2017

Conversation

selrond
Copy link
Contributor

@selrond selrond commented Nov 4, 2017

I also updated README and normalized mixed indentation to tabs

@xabikos
Copy link
Owner

xabikos commented Nov 12, 2017

@selrond thanks for your contribution and the PR.
I would be more than happy to incorporate the additional snippet. But before merging the PR I would request you to revert back the changes regarding the spaces on the snippets.

As this is a pure json file I would prefer to keep the convention of having two spaces. Is this fine by you?

@selrond
Copy link
Contributor Author

selrond commented Nov 13, 2017

@xabikos I've converted the indentation to spaces

@xabikos xabikos merged commit 1921625 into xabikos:master Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@selrond @xabikos